store upperme once in variable

[backmeupscotty.git] / backmeupscotty

diff --git a/backmeupscotty b/backmeupscotty
index e0689a042a60240b16f3d0cfac77a6e0e5c52c4b..ad2fa6582ec1303bef176c47eaab0335ee03da67 100644 (file)
--- a/backmeupscotty
+++ b/backmeupscotty
@@ -6,16 +6,14 @@ ARCHIVE_KEEPNBACKUPS=30
 ARCHIVE_KEEPNDAYS=30
 BACKUP_RUNEVERYNTHDAY=1
 
 ARCHIVE_KEEPNDAYS=30
 BACKUP_RUNEVERYNTHDAY=1
 

-function upperme {
-    echo $(basename $0) | tr '[:lower:]' '[:upper:]'
-}
+_UPPERME=$(echo $(basename $0) | tr '[:lower:]' '[:upper:]')

 
 function scottyinfo {
 
 function scottyinfo {

-    echo $(upperme): $@ 
+    echo $_UPPERME: $@ 

 }
 
 function scottyerror {
 }
 
 function scottyerror {

-    echo $(upperme): $@ >&2 
+    echo $_UPPERME: $@ >&2 

 }
 
 function ssh255 {
 }
 
 function ssh255 {


@@ -125,6 +123,12 @@ function scottysync {
     done
 }
 
     done
 }
 

+function deleteLock {
+    if ! rmdir /var/lock/$(basename $0); then
+       scottyerror "Could not delete lockfile /tmp/$(basename $0).lock!"
+    fi
+}
+

 function cleanup_abort {
     scottyerror "Caught exit signal! Cleaning up."
 
 function cleanup_abort {
     scottyerror "Caught exit signal! Cleaning up."
 


@@ -135,6 +139,8 @@ function cleanup_abort {
        kill $(jobs -p)
     fi
 
        kill $(jobs -p)
     fi
 

+    deleteLock
+

     exit
 }
 
     exit
 }
 


@@ -146,6 +152,11 @@ function prepare {
     scottyinfo "No prepare function was defined."
 }
 
     scottyinfo "No prepare function was defined."
 }
 

+function cleanup_normal {
+    cleanup
+    deleteLock
+}
+

 function printhelp {
     cat <<EOF
 Usage: $(basename $0) [OPTION]...
 function printhelp {
     cat <<EOF
 Usage: $(basename $0) [OPTION]...


@@ -191,14 +202,14 @@ function backmeupscotty {
     prepare
     scottysync
 
     prepare
     scottysync
 

-    trap cleanup EXIT
+    trap cleanup_normal EXIT

 
     exit 0
 }
 
 
     exit 0
 }
 

-exec 200>/var/run/$(basename $0).pid
-if ! flock -n 200; then
+if ! mkdir /var/lock/$(basename $0); then

     scottyerror "Another instance of $(basename $0) is still running!"
     exit 1
     scottyerror "Another instance of $(basename $0) is still running!"
     exit 1

+else
+    trap deleteLock EXIT

 fi
 fi

-echo $$ 1>&200